Add OCI source annotation to link back to source repo #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `org.opencontainers.image.source` label to the built container images. This label is helpful for tools to be able to link back from the container image to the source repo. For example, for those that use Renovate to help auto update dependencies, this will result in the latest releases release notes/changelog being included in the PR which is very handy!
| @@ -127,3 +127,5 @@ COPY --from=ublock-build /etc/linkding/uBlock0.chromium uBlock0.chromium/ | |||
| RUN mkdir -p chromium-profile && chown -R www-data:www-data chromium-profile | |||
| # enable snapshot support | |||
| ENV LD_ENABLE_SNAPSHOTS=True | |||
|
|
|||
| LABEL org.opencontainers.image.source="https://github.com/sissbruecker/linkding" | |||
There was a problem hiding this comment.
Thanks! Since the Dockerfiles contain multiple build stages that are used to generate separate images (linkding and linkding-plus), I assume that the LABEL either needs to be set for both, or on the linkding build stage, which is the basis for linkding-plus.
There was a problem hiding this comment.
Oh you're right. I just assumed the last stage was the published one. I'll edit my commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
org.opencontainers.image.sourcelabel to the built container images.This label is helpful for tools to be able to link back from the container image to the source repo.
For example, for those that use Renovate to help auto update dependencies, this will result in the latest releases release notes/changelog being included in the PR which is very handy!