Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to phpunit 6 #21

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update to phpunit 6 #21

wants to merge 7 commits into from

Conversation

sirbrillig
Copy link
Owner

@sirbrillig sirbrillig commented Oct 23, 2017

This updates Spies to be compatible with PHPUnit 6.x.

The unfortunate side effect is that it is no longer compatible with PHPUnit 5.x since PHPUnit_Framework_Constraint was removed in favor of \PHPUnit\Framework\Constraint\Constraint.

To compromise, I added a class alias so that if PHPUnit_Framework_Constraint does not exist, it is created.

  • Is the alias safe? Do we need a major version instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant