Do not search for nested arrow functions outside of arrow functions #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#334 caused a performance regression. This line was now performing a large scope search for every token when searching for a variable's scope in order to find the scope of nested arrow functions, even if the current variable was not inside an arrow function.
In this diff we prevent searching for the arrow function's scope opener if we are not inside an arrow function. That does not speed up searching for the arrow function scope itself but it will prevent this cost being paid for every variable.
Fixes #340