Skip to content

Commit

Permalink
GH Actions: update for the release of PHP 8.3 (#312)
Browse files Browse the repository at this point in the history
... which is expected later today.

* Builds against PHP 8.3 are no longer allowed to fail.
* Update PHP version on which code coverage is run (high should now be 8.3).
* Add _allowed to fail_ build against PHP 8.4.

Co-authored-by: jrfnl <[email protected]>
  • Loading branch information
jrfnl and jrfnl authored Nov 23, 2023
1 parent 16c4768 commit fdac475
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,17 @@ jobs:
# - PHP 8.0 needs PHPCS 3.5.7+ to run without errors.
# - PHP 8.1 needs PHPCS 3.6.1+ to run without errors.
# - PHP 8.2 needs PHPCS 3.6.1+ to run without errors.
# - PHP 8.3 needs PHPCS 3.8.0+ to run without errors (though the errors don't affect this package).
#
# The matrix is set up so as not to duplicate the builds which are run for code coverage.
php: ['5.5', '5.6', '7.0', '7.1', '7.2', '7.3']
phpcs_version: ['3.5.6', 'dev-master']

include:
# Make the matrix complete without duplicating builds run in code coverage.
- php: '8.3'
phpcs_version: '3.6.1'

- php: '8.2'
phpcs_version: '3.6.1'

Expand All @@ -54,12 +58,12 @@ jobs:
phpcs_version: 'dev-master'

# Experimental builds.
- php: '8.3' # Nightly.
- php: '8.4' # Nightly.
phpcs_version: 'dev-master'

name: "Test: PHP ${{ matrix.php }} on PHPCS ${{ matrix.phpcs_version }}"

continue-on-error: ${{ matrix.php == '8.3' }}
continue-on-error: ${{ matrix.php == '8.4' }}

steps:
- name: Checkout code
Expand Down Expand Up @@ -93,15 +97,15 @@ jobs:
# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-php-dependencies-with-composer
- name: Install Composer dependencies - normal
if: ${{ matrix.php != '8.3' }}
if: ${{ matrix.php != '8.4' }}
uses: "ramsey/composer-install@v2"
with:
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

# For the PHP "nightly", we need to install with ignore platform reqs as not all dependencies allow it yet.
- name: Install Composer dependencies - with ignore platform
if: ${{ matrix.php == '8.3' }}
if: ${{ matrix.php == '8.4' }}
uses: "ramsey/composer-install@v2"
with:
composer-options: --ignore-platform-req=php
Expand All @@ -121,7 +125,7 @@ jobs:
strategy:
matrix:
include:
- php: '8.2'
- php: '8.3'
phpcs_version: 'dev-master'
- php: '7.4'
phpcs_version: '3.5.6'
Expand Down

0 comments on commit fdac475

Please sign in to comment.