Replace empty() and some isset() calls
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `empty()` works on null undefined without a warning, it also hides bugs from static analysis (causing the bug in #99). This change should have the same effect while not ignoring warnings.
Again, this is because `empty()` allows undefined values and hides potential bugs from static analysis.
psalm reports `RiskyTruthyFalsyComparison` for this line but I can't figure out why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
empty()andisset()work on undefined variables without a warning, they also hide bugs from static analysis (causing the bug in #99). Here we replace most uses of these functions with more precise alternatives that will produce warnings and errors if the variables they check have a typo.This PR also fixes a bunch of new static analysis errors that relate to implicit boolean guards not being explicit enough.