Update to esm #183
Draft
Update to esm #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has some sort of node requirement which prevents upgrading anything else.
The main process should have no assets.
updatedAt and gitnewsSeenAt are quite different and their types were wrong.
sirbrillig
added a commit
that referenced
this pull request
Sep 7, 2024
This prevents the issue described here: sindresorhus/electron-store#276 The recommended solution that issue is to convert the entire project to ESM, which I've attempted in #183, but it doesn't seem to work because of incompatibilities between Webpack and Electron Forge that I haven't been able to resolve. So for now I'm just going to downgrade. (The app works fine with or without the errors.)
sirbrillig
added a commit
that referenced
this pull request
Sep 7, 2024
* Remove minor TS warnings * Temporarily remove eslint from dependencies It has some sort of node requirement which prevents upgrading anything else. * Upgrade all packages to latest * Update date-fns calls to new version * Remove asset loading in main process WebPack config The main process should have no assets. * Downgrade webpack-asset-relocator-loader to 1.7.3 See electron/forge#3600 * Fix calls to formatDistanceToNow by fixing definitions of timestamps updatedAt and gitnewsSeenAt are quite different and their types were wrong. * Install octokit * Update tests to remove chai and sinon * Remove chai and sinon * Set node version in GH actions * Fix TS errors in middleware * Remove octokit * Add semver types * Downgrade electron-store to 8.2 This prevents the issue described here: sindresorhus/electron-store#276 The recommended solution that issue is to convert the entire project to ESM, which I've attempted in #183, but it doesn't seem to work because of incompatibilities between Webpack and Electron Forge that I haven't been able to resolve. So for now I'm just going to downgrade. (The app works fine with or without the errors.) * Ignore extras directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch from #182 attempting to update the whole package to ESM, but it seems as though getting Electron Forge, TypeScript, ESM, Babel, and Webpack to all work together may be impossible currently.
Current status:
tsc works but the dev server fails because the transpiled main.js file from webpack is apparently cjs and so won't load correctly in an ESM environment. I don't know how to force webpack to leave ESM alone.