Fix constructor-based checks for fake Date no longer pass after installing #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatso83
approved these changes
Oct 21, 2024
| @@ -450,7 +450,7 @@ function withGlobal(_global) { | |||
|
|
|||
| // ensures identity checks using the constructor prop still works | |||
| // this should have no other functional effect | |||
| this.constructor = Date; | |||
| this.constructor = NativeDate; | |||
There was a problem hiding this comment.
Good catch, this was naively working in the tests due to it being the same when not overwritten. This is what I meant to have written 😄
There was a problem hiding this comment.
👍 I was initially very surprised, but makes sense now — since this happens every time a fake Date is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fixes #511 (fix for #510) no longer working after the clock had been installed and global
Dateassigned to the fake.Background (Problem in detail) - optional
Once
ClockDateProxywas installed to globalDate(to my surprise) the constructor reference on it was 'updated' to point toClockDateProxy.Thanks again for the help!