Fix reported issues #1886
Merged
Fix reported issues #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call to class function afterButtonPressed to allow default call to base button settings quill_icon_button: L26 build for isSelected updated to call afterButtonPressed = same as if not selected QuillController _updateSelection removed param=source because not used; added new param insertNewline when true set tog to style of preceding char (last entered); updated replaceText to call _updateSelection for NL document collectStyle: Selecting the start of a line, user expects the style to be the visible style of the line including inline styles
insert at start of line uses style for line
Fix: Toolbar drop buttons clipped when !multiRowsDisplay
Dart Formatted
# Conflicts: # lib/src/models/config/editor/editor_configurations.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix exception thrown for Attribute H1 in Toolbar.
Fix custom block attribute.
Fix iconColor in QuillToolbarColorButtonOptions always returns null.
Fix copy embedded nodes.
Related Issues
Checklist
CHANGELOG.mdnor the package version inpubspec.yamlfiles../scripts/before_push.shand it all passed successfullyBreaking Change
Does your PR require developers to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).