Restore old functionaliy for some Quill toolbar classes #1633
+701
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we solve the conflicts and merge this, does that fix your issue? |
I restored only buttons which I used but there are other ones which are not fixed. So if button in web looks like
before modifications it should looks like so after modifications but not like
I tested example app so you may read #1628 (comment) for results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today I have again spent time to make my project looks as it must. I do not do anything critical just restore the funcitonality of some toolbar classes as they were. You may consider this PR as a starting point for all other buttons which I didn't change. The only thing is required is change call of
QuillToolbarIconButtoninbuildmethods of embed buttons, search button and maybe others. You may see what I did. I also restored oldQuillToolbarSelectAlignmentButtonand save it asQuillToolbarSelectTextAlignmentButton.I need this modifications to make my project compiled and continue working. You may merge this PR or use it for understanding how to make package backward compatible. It will take less effors.
Related Issues
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).