Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolbarOptions is not hidden after start typing on iOS #2412

Open
1 task done
khlebobul opened this issue Dec 10, 2024 · 1 comment
Open
1 task done

ToolbarOptions is not hidden after start typing on iOS #2412

khlebobul opened this issue Dec 10, 2024 · 1 comment
Labels
bug Something isn't working iOS Issues or feature requests specific to the iOS platform. regression For issues where a previously working feature is now broken due to recent changes.

Comments

@khlebobul
Copy link

Is there an existing issue for this?

Use case

I'm trying to add a feature to hide ToolbarOptions on iOS when the user starts typing. Right now ToolbarOptions remains.

A complete shutdown is not an alternative

toolbarOptions: ToolbarOptions(copy: false, cut: false, paste: false, selectAll: false),

Proposal

How it works now ⬇️

Simulator Screen Recording - iPhone 15 - 2024-12-10 at 12 39 00

How it works, for example, in default iOS notes ⬇️

ScreenRecording_12-10-2024.12-33-09_1.mov
@khlebobul khlebobul added the enhancement New feature or request label Dec 10, 2024
@EchoEllet
Copy link
Collaborator

I'm trying to add a feature to hide ToolbarOptions on iOS when the user starts typing. Right now ToolbarOptions remains.
How it works now

The current behavior is a regression, a bug introduced by the magnifier feature (#2026):

$ git clone --branch v9.5.23 --depth 1 [email protected]:singerdmx/flutter-quill.git flutter-quill-before-magnifier
$ (cd flutter-quill-before-magnifier/example && flutter run)

Tested with 9.5.23 (before 9.6.0):

iOSBeforeMagnifierFeature.mov

Tested with 10.8.5 and 11.0.0-dev.14 (after 9.6.0):

iOSAfterMagnifierFeature.mov

Refer to #2406 (a suggestion for reverting the feature and related changes for now).

@EchoEllet EchoEllet added bug Something isn't working iOS Issues or feature requests specific to the iOS platform. regression For issues where a previously working feature is now broken due to recent changes. and removed enhancement New feature or request labels Dec 10, 2024
@EchoEllet EchoEllet changed the title Hide ToolbarOptions after you start typing on iOS ToolbarOptions is not hidden after start typing on iOS Dec 10, 2024
@EchoEllet EchoEllet mentioned this issue Dec 11, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iOS Issues or feature requests specific to the iOS platform. regression For issues where a previously working feature is now broken due to recent changes.
Projects
None yet
Development

No branches or pull requests

2 participants