Revert the magnifier feature #2406
Assignees
Labels
android
Issues or feature requests specific to the Android platform.
breaking change
This change introduces an incompatibility that requires adjustments in dependent code or packages, a
feedback requested
Seeking user input to improve features, resolve issues, or plan future updates.
in progress
This issue or feature is currently being worked on by someone.
iOS
Issues or feature requests specific to the iOS platform.
major
Significant impact on the user experience or performance. This issue should be addressed in the next
mobile
Issues or feature requests related to mobile platforms (e.g., Android and iOS).
notice
This is a notice or information that may be important for users to be aware of.
Comments
EchoEllet
added
notice
This was referenced Dec 4, 2024
|
Agree |
EchoEllet
added
the
in progress
Draft
8 tasks
|
I agree, I'm having a lot of problems because of this magnifier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Revert the magnifier feature (#2026) in v11 (as a breaking change) with all related changes.
It's already marked as experimental in v11.
Reason
Too many regressions, bugs, and workarounds, made changes to many parts of the API in not very good design, removed an assert check to dodge issues, not implemented cleanly.
I don't have a strong opinion upon the revert since it doesn't affect me but I do have about this: We should focus on improving existing features (as it's done with #2403), improve code coverage, and docs, fix existing issues, bugs, the not very good design we have before we move further forward, we have discussed this many times in different threads (e.g., #2235) with more details and reasons (might create an issue for collecting all such details) and it seems we agreed on the same opinion.
Implementing solutions poorly without understanding the details or doing them properly is strongly discouraged, as it will cause the project to fall apart in the long term.
This is not a justification though, we should test features thoughtfully before releasing them as stable, otherwise, all users including the end-users will be a test site.
Issue #1504 will reopened if reverted.
Regressions
I found some other bugs while testing and working on different areas (e.g., #2323 (comment) or #2323 (comment)).
Related PRs
PRs that made fixes to the issue:
PRs to implement the feature:
The text was updated successfully, but these errors were encountered: