hide magnifier when entire toolbar overlay is hidden #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtallenca
changed the title
|
Thanks, I will review soon. |
EchoEllet
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Looks good though due to the code coverage and the way this feature is written, we will likely have regression or code that's no longer straightforward to maintain, I still suggest reverting the magnifier feature (see #2406). Some bugs and regressions are still not solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have many users enjoying this feature - but have a couple dozen or so stuck magnifier complaints as well. I took a look at the code and there are a couple of paths where the selectionOverlay is dismissed via a call to hide() that takes care of the toolbar menu but not the magnifier. When hide() is called directly, not in the regular disposal path, the selectionOverlay is removed before the call to remove the magnifier. In those cases, the magnifier will be left floating on the screen. This PR fixes that scenario.
Related Issues
Type of Change