-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stuck magnifying glass #2379
Comments
I'm thinking about reverting the magnifier feature completely (#2026) in v11 with all related changes, too many regressions, bugs, and workarounds (#2376, #2153, #2128, #2124, #2049, #2391, #2401), it made changes to many parts of the API, removed an assert check to dodge issues, not implemented cleanly. |
If someone faces the same issue, a workaround could be to add |
I have many users enjoying this feature - but have a couple dozen or so stuck magnifier complaints as well. I took a look at the code and there are a couple of paths where the selectionOverlay is dismissed via a call to hide() that takes care of the toolbar menu but not the magnifier. When hide() is called directly, not in the regular disposal path, the selectionOverlay is removed before the call to remove the magnifier. In those cases, the magnifier will be left floating on the screen. We're testing a branch of 10.8.5 now with a simple fix for this. Try out the following override: flutter_quill:
git:
url: https://github.com/mtallenca/flutter-quill
ref: 10.8.5_magnification |
Is there an existing issue for this?
Flutter Quill version
10.8.5
Steps to reproduce
Expected results
The magnifying glass and the selection is adjusted to the new position of the marker.
Actual results
Markers do disappear and the magnifying glass is stuck until the app is restarted.
Additional Context
Screenshots / Video demonstration
Logs
[Paste your logs here]
The text was updated successfully, but these errors were encountered: