-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow publishConfig.registry
to be npm default registry when using Yarn berry
#750
Conversation
Looking at the other usages of |
Updated. Anyway I'm not familiar with codebase but seems we are not reading user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure about .npmrc, but this is an improvement on the status quo
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [np](https://github.com/sindresorhus/np) | devDependencies | patch | [`10.0.6` -> `10.0.7`](https://renovatebot.com/diffs/npm/np/10.0.6/10.0.7) | --- ### Release Notes <details> <summary>sindresorhus/np (np)</summary> ### [`v10.0.7`](https://github.com/sindresorhus/np/releases/tag/v10.0.7) [Compare Source](sindresorhus/np@v10.0.6...v10.0.7) - Allow `publishConfig.registry` to be npm default registry when using Yarn berry ([#​750](sindresorhus/np#750)) [`6c5eee3`](sindresorhus/np@6c5eee3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119--> Reviewed-on: https://git.vylpes.xyz/RabbitLabs/vylbot-app/pulls/456 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [np](https://github.com/sindresorhus/np) | devDependencies | patch | [`10.0.5` -> `10.0.7`](https://renovatebot.com/diffs/npm/np/10.0.5/10.0.7) | --- ### Release Notes <details> <summary>sindresorhus/np (np)</summary> ### [`v10.0.7`](https://github.com/sindresorhus/np/releases/tag/v10.0.7) [Compare Source](sindresorhus/np@v10.0.6...v10.0.7) - Allow `publishConfig.registry` to be npm default registry when using Yarn berry ([#​750](sindresorhus/np#750)) [`6c5eee3`](sindresorhus/np@6c5eee3) ### [`v10.0.6`](https://github.com/sindresorhus/np/releases/tag/v10.0.6) [Compare Source](sindresorhus/np@v10.0.5...v10.0.6) - Fix usage with `pnpm` and `--any-branch` or `--branch` ([#​745](sindresorhus/np#745)) [`d0c1493`](sindresorhus/np@d0c1493) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy40MzEuNCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/189 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Allow
publishConfig.registry
to be'https://registry.npmjs.org'
Though I usesTurns out both used in npm docs.https://registry.npmjs.org/
, but the default value does not include the trailing slash, so I'm going to change my package.json and live with it. 😄I didn't change#750 (comment)isExternalRegistry
utility, since I found it's used for different purposeFixes #749