Ensure that Node.js version bumps are done in major releases #686
Conversation
We just ignore it. That's an extreme edge-case anyway.
"Targeting a major Node.js version is a breaking change and requires a major version bump"?
It shouldn't do anything if there are no previous version to compare to. |
| @@ -62,6 +63,18 @@ const prerequisiteTasks = (input, pkg, options) => { | |||
| newVersion = Version.getAndValidateNewVersionFrom(input, pkg.version); | |||
| }, | |||
| }, | |||
| { | |||
| title: 'Check for Node version bump', | |||
There was a problem hiding this comment.
| title: 'Check for Node version bump', | |
| title: 'Check for Node.js version bump', |
I agree, I meant more “what does the code do since it doesn’t check for that case”.
Are we only erroring on major Node changes, or any change? And for the target field in |
Any change. Any change to the target Node.js version is a potentially breaking change. |
tommy-mitchell
changed the title
|
Bump :) |
|
I’m waiting until #689 is finished before completing this, as it has a better test suite. I’m close to being done with it. |
|
Bump :) |
Closes #88. Currently just a scaffold for a new prerequisite task. Related: sindresorhus/read-pkg#28
Some questions:
The Node version has increased, but this release is not a major version., but that's not the best. Any ideas for improvements?Related to the first question, it just struck me - what happens with #681 on the first release? I don't think I took that case into account.