Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for serializing Color.Resolved #171

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Add support for serializing Color.Resolved #171

merged 2 commits into from
Apr 20, 2024

Conversation

sindresorhus
Copy link
Owner

Fixes #157

@sindresorhus sindresorhus changed the title Add support for serializing Color.Resolved Add support for serializing Color.Resolved Apr 20, 2024
@sindresorhus
Copy link
Owner Author

@hank121314 No need for custom bridge, right? 0192f45

hank121314
hank121314 approved these changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@hank121314 hank121314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, cause Color.Resolved already conforms to Codable will use Defaults.CodableBridge to do the serialization and deserialization.,

@sindresorhus sindresorhus merged commit ce45591 into main Apr 20, 2024
4 checks passed
@sindresorhus sindresorhus deleted the color-resolved branch April 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hank121314 hank121314 hank121314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Color.Resolved
2 participants
@sindresorhus @hank121314