Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apache Superset icon #10871

Merged
merged 3 commits into from
May 28, 2024

Conversation

10xLaCroixDrinker
Copy link
Contributor

Apache Superset simpleicons preview

Issue: closes #3508

Popularity metric: 58.9k stars upward trend

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Seems the inconsistency between the logo site and the project repo that was present when #3508 was opened has been resolved.

I also tried two other treatments for this. I'm happy to update the PR to either if desired.

Expand to see alternative treatments

image

IMG_5549

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Apr 28, 2024
@PratyushJayachandran
Copy link
Member

I vote for this treatment:
326268486-a887e28b-a59a-4824-b7a1-962778dfdc9f

@adamrusted
Copy link
Member

I agree with @PratyushJayachandran - would you mind submitting that version please @10xLaCroixDrinker?

@10xLaCroixDrinker
Copy link
Contributor Author

Updated!

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @10xLaCroixDrinker!

@adamrusted adamrusted merged commit 2808547 into simple-icons:develop May 28, 2024
3 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/superset branch May 28, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Apache Superset
3 participants