Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript #1715

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade TypeScript #1715

wants to merge 1 commit into from

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Oct 7, 2024

TypeScript 5.5 can:

TypeScript 5.6 can:

@@ -5,24 +5,19 @@
"target": "esnext",
"lib": ["dom", "dom.iterable", "esnext"],
"jsx": "react-jsx",
"allowJs": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually needed.

Comment on lines -16 to -17
"declaration": true,
"declarationMap": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to tsconfig files in packages subfolders, where it is actually needed. This was causing issues in the storybook project.

Comment on lines -24 to -25
"importsNotUsedAsValues": "error",
"ignoreDeprecations": "5.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I linked to an article that discussed this, I think: https://johnnyreilly.com/typescript-5-importsnotusedasvalues-error-eslint-consistent-type-imports -- it's ESLint's job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant