Fetch boolean data from h5grove as binary #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Sep 9, 2024
packages/app/src/providers/h5grove/__snapshots__/h5grove-api.test.ts.snap
Show resolved
Hide resolved
loichuder
approved these changes
Sep 13, 2024
|
|
||
| import type { DataProviderApi } from './api'; | ||
|
|
||
| export const CANCELLED_ERROR_MSG = 'Request cancelled'; | ||
|
|
||
| export function typedArrayFromDType(dtype: DType) { | ||
| if (isEnumType(dtype)) { | ||
| if (isEnumType(dtype) || isBoolType(dtype)) { |
There was a problem hiding this comment.
Sorry for the dumb question: isn't bool a particular type of enum ? So that isEnumType should encompass bool ?
There was a problem hiding this comment.
We split the two in our internal types and the purpose of these guards is to narrow our internal types. We need two separate types so Primitive<BooleanType> can resolve to number | boolean. But we may be able to reconsider this choice with #1679 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1692
Requires [email protected], which I've just released. I've also updated the demo server on Bosquet.
I'll add client-side code to support datatypes in my next PR.