only run errorpone in java 17+ #837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
might be strange for devs working with java11, but our CI will catch it anyway Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
errorprone17only
branch
from
a571026 to
06afe4a
Compare
|
I thought we use toolchains for the build, so the build should always use Java 17 no matter which Java is the default. Isn't it the case? |
|
Ah, we don't have toolchains in sigstore-java yet. |
|
We also want to keep java11 compat, we have all our tests run in Java 11 as well on CI. |
|
We'd better use Java 17 for the build, and use Using Java 17 for the build would avoid us running into javac11 bugs, and it would make all the devs produce pretty-much the same bytecode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might be strange for devs working with java11, but our CI will catch it anyway