make signature extension .sigstore.json #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
signature-extension
branch
from
59bdcb8
to
869a672
Compare
vlsi
reviewed
Apr 27, 2024
.../sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/SigstoreSignExtension.kt
Outdated
Show resolved
Hide resolved
vlsi
reviewed
Apr 27, 2024
...adle/sigstore-gradle-sign-base-plugin/src/main/kotlin/dev/sigstore/sign/SigstoreSignature.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
signature-extension
branch
from
869a672
to
ab69961
Compare
|
@vlsi when you get a chance, can we do an another look over and then we can maybe start another release |
vlsi
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the best way I could do this (@vlsi perhaps not kotlin style). There seems to be a way that gradle is generating extensions for derived artifacts that isn't compatible with our double
.extension: gradle/gradle#28969 but I've worked around that for now.