Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonscheme2dataclass plugin to 6.0.0 #305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

loosebazooka
Copy link
Member

Signed-off-by: Appu Goundan [email protected]

@loosebazooka loosebazooka requested a review from vlsi January 14, 2023 18:10
@loosebazooka loosebazooka added the safe to test conformance testing label label Jan 14, 2023
@vlsi
Copy link
Collaborator

vlsi commented Jan 23, 2023

For reference, the failure is caused by empty @param data javadocs generated on constructors as follows: joelittlejohn/jsonschema2pojo#1463

    /**
     * 
     * @param data
     * @param signature
     */
    public HashedRekord(Signature signature, Data data) {
        super();
        this.signature = signature;
        this.data = data;
    }

@loosebazooka
Copy link
Member Author

I think I'm going to ignore the javadoc generation on this subpath for now.

@loosebazooka
Copy link
Member Author

javadoc is really annoying to configure. Might sit on this for a while. Another option is change the package of the generated model from dev.sigstore.rekor -> dev.sigstore.rekor.model and exclude just that package path (easy)

@vlsi
Copy link
Collaborator

vlsi commented Feb 1, 2023

@loosebazooka , another idea: add regexp-based processing to kill ill javadocs or replace them with @param data data.

WDYT?

@vlsi
Copy link
Collaborator

vlsi commented Feb 1, 2023

Using a separate package for generated code looks good to me.

@loosebazooka
Copy link
Member Author

@loosebazooka , another idea: add regexp-based processing to kill ill javadocs or replace them with @param data data.

Hah, I think I would rather not do this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test conformance testing label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants