Add gitsign verify #262
Merged
Add gitsign verify #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlynch
force-pushed
the
cmd-verify
branch
4 times, most recently
from
92d8ebc
to
e11d0e7
Compare
wlynch
force-pushed
the
cmd-verify
branch
5 times, most recently
from
430406a
to
f44784f
Compare
This adds a new subcommand that mirrors cosign verify for certificate claim verification. Previously we relied on `git verify-commit` for commit verification. While this did check that the signature was valid and it exists in rekor, it did not check whether the identity was what was expected, because Git does not give controls over this via the commit signature interface. This command provides this functionality. Also adds a warning to the output of the `git verify-commit` output warning users that that verification mechanism may not be complete. Signed-off-by: Billy Lynch <[email protected]>
priyawadhwa
approved these changes
Mar 23, 2023
cpanato
approved these changes
Mar 23, 2023
hectorj2f
approved these changes
Mar 23, 2023
hectorj2f
reviewed
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new subcommand that mirrors cosign verify for certificate
claim verification.
Previously we relied on
git verify-commitfor commit verification.While this did check that the signature was valid and it exists in
rekor, it did not check whether the identity was what was expected,
because Git does not give controls over this via the commit signature
interface.
This command provides this functionality.
Also adds a warning to the output of the
git verify-commitoutputwarning users that that verification mechanism may not be complete.
Fixes #241
Note: e2e may break - because of the id-token restrictions requiring us to run from main, idk if this actually works yet. I'll fix it if it breaks in another PR.
Release Note
gitsign verifysubcommand for verifying certificate claims.git verify-commitoutput warning about certificate claim checks.Documentation
✅