Add support for checking cert email against user config before signing. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlynch
force-pushed
the
commiter-verify
branch
from
a9c216f
to
d5ac5e0
Compare
This change adds a new config option: gitsign.matchCommitter. This option checks whether the certificate fetched matches the user configured email/name. For human users, this generally means that the SAN email in the cert matches the `user.email` Git config option. For non-email based identities (e.g. machine users), the SAN URI can be specified as the user name (since the URI isn't a valid email). Gitsign requires at least one condition to match for the check to succeed. This change does *not* enforce any constraints on verification, since this requires additional checking to know what IdP is considered valid. Signed-off-by: Billy Lynch <[email protected]>
wlynch
force-pushed
the
commiter-verify
branch
from
d5ac5e0
to
60b6656
Compare
hectorj2f
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a new config option: gitsign.matchCommitter. This option checks whether the certificate fetched matches the user configured email/name.
For human users, this generally means that the SAN email in the cert matches the
user.emailGit config option.For non-email based identities (e.g. machine users), the SAN URI can be specified as the user name (since the URI isn't a valid email).
Gitsign requires at least one condition to match for the check to succeed.
This change does not enforce any constraints on verification, since this requires additional checking to know what IdP is considered valid.
Fixes #104
Release Note
gitsign.matchCommitterconfig option. This option checks whether the certificate fetched matches the user configured email/name.Documentation
✅