Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CPUThrottlingHigh alert from prometheus-operated #43

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Remove CPUThrottlingHigh alert from prometheus-operated #43

merged 1 commit into from
Jul 28, 2020

Conversation

lnovara
Copy link
Contributor

@lnovara lnovara commented Jul 23, 2020

This alert is flooding us on basically every cluster without any added benefit, therefore I'm removing it.

Refs:

@lnovara lnovara added the bug Something isn't working label Jul 23, 2020
@lnovara lnovara self-assigned this Jul 23, 2020
angelbarrera92
angelbarrera92 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@angelbarrera92 angelbarrera92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nutellinoit
nutellinoit approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@nutellinoit nutellinoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Rampage1xx
Rampage1xx approved these changes Jul 23, 2020
View reviewed changes
Copy link

@Rampage1xx Rampage1xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@ralgozino
Copy link
Member

lgtm! I've opened a PR to remove the alert from the docs also:
https://github.com/sighupio/kfd-docs/pull/45

lzecca78
lzecca78 approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@lzecca78 lzecca78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ LGTM

iknite
iknite approved these changes Jul 24, 2020
View reviewed changes
Copy link

@iknite iknite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ralgozino ralgozino linked an issue Jul 28, 2020 that may be closed by this pull request
CPUThrottlingHigh alert too easily triggered #36
Closed
@ralgozino ralgozino merged commit e3a85f2 into master Jul 28, 2020
@lnovara lnovara mentioned this pull request Sep 23, 2020
Merged
angelbarrera92 added a commit that referenced this pull request Sep 23, 2020
@angelbarrera92
Remove CPUThrottlingHigh alert. Previously removed in #43
3a1ca26
angelbarrera92 added a commit that referenced this pull request Sep 23, 2020
@angelbarrera92
Remove CPUThrottlingHigh alert. Previously removed in #43
23ef846
nandajavarma added a commit that referenced this pull request Aug 25, 2021
@nandajavarma
Remove CPUThrottlingHigh as it was previously removed in #43
37e30ac
nandajavarma added a commit that referenced this pull request Aug 25, 2021
@nandajavarma
Remove CPUThrottlingHigh as it was previously removed in #43
1cf9178
nandajavarma added a commit that referenced this pull request Aug 26, 2021
@nandajavarma
Remove CPUThrottlingHigh as it was previously removed in #43
a4c3bc5
nandajavarma added a commit that referenced this pull request Aug 26, 2021
@nandajavarma
Remove CPUThrottlingHigh as it was previously removed in #43
db50044
nandajavarma added a commit that referenced this pull request Aug 26, 2021
@nandajavarma
Remove CPUThrottlingHigh as it was previously removed in #43
04f2676
nandajavarma added a commit that referenced this pull request Aug 26, 2021
@nandajavarma
Remove CPUThrottlingHigh as it was previously removed in #43
7a705ae
@lnovara lnovara deleted the hotfix/prometheus-operated-remove-cputhrottling branch October 18, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutellinoit nutellinoit nutellinoit approved these changes

@Rampage1xx Rampage1xx Rampage1xx approved these changes

@angelbarrera92 angelbarrera92 angelbarrera92 approved these changes

@ralgozino ralgozino ralgozino approved these changes

@lzecca78 lzecca78 lzecca78 approved these changes

@iknite iknite iknite approved these changes

@phisco phisco Awaiting requested review from phisco

Assignees

@lnovara lnovara

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPUThrottlingHigh alert too easily triggered
7 participants
@lnovara @ralgozino @iknite @lzecca78 @angelbarrera92 @Rampage1xx @nutellinoit