Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/checkbox): allow multiline labels and align checkbox at the top #1273

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

nuke-ellington
Copy link
Collaborator

๐Ÿ’ก What is the current behavior?

GitHub Issue Number: #1227

๐Ÿ†• What is the new behavior?

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

@nuke-ellington nuke-ellington added this to the 2.x.x milestone May 10, 2024
Copy link

changeset-bot bot commented May 10, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: 32a5227

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Major
@siemens/ix-aggrid Patch
@siemens/ix-angular Major
@siemens/ix-react Major
@siemens/ix-vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux added the V3 Will be part of the upcoming v3 release label May 21, 2024
@danielleroux danielleroux changed the base branch from main to v3 May 21, 2024 10:25
@danielleroux danielleroux changed the base branch from v3 to release-3.0.0 June 14, 2024 13:47
@danielleroux danielleroux merged commit e8f825f into release-3.0.0 Jun 17, 2024
15 checks passed
@danielleroux danielleroux deleted the fix/1227-checkbox-multi-line branch June 17, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 Will be part of the upcoming v3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants