-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add device-mapper package #791
Conversation
I decided to depend on the kernel-build using it as a cache to build the required modules in this package rather than modify the underlying kernel-build configs. I was unable to make this work due to make invalidating the kernel-build cache every time I built the package resulting in errors while loading the module. I assume that's what #694 aims to address? To get it working locally I ended up making kernel-build a package in the makefile and pushing it to docker, then depending on that image instead of the stage. Works fine as long as this package and the kernel package use the same kernel-build cache. |
related: #124 |
buildkit needs some config to tell it to no do GC, https://github.com/siderolabs/build-container/blob/main/hack/scripts/buildkit.toml, I'll clean up the PR and include the config into the standard place. Does this require any userspace binaries/daemon? |
Not for the piraeus-operator / linstor use case. |
c8cfa47
to
ac2b5a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's enable this as a =m
setting by default and ship it with Talos
(hopefully the module is small)
ac2b5a5
to
832c150
Compare
I've updated the kernel configs and ran |
I'll get back to this next week, apologies for the delay |
Add `CONFIG_DM_THIN_PROVISIONING=m`. Signed-off-by: Noel Georgi <[email protected]>
832c150
to
847a9c3
Compare
/ok-to-test |
/m |
Pull in dm-modules. Ref: siderolabs/pkgs#791 Diff: ```bash ❯ diff -r --color _out/kernel-a/lib/modules/6.1.51-talos/modules.dep _out/kernel-b/lib/modules/6.1.51-talos/modules.dep 100a101 > kernel/drivers/md/dm-bio-prison.ko: 102a104 > kernel/drivers/md/persistent-data/dm-persistent-data.ko: 103a106 > kernel/drivers/md/dm-thin-pool.ko: kernel/drivers/md/persistent-data/dm-persistent-data.ko kernel/drivers/md/dm-bio-prison.ko ``` Signed-off-by: Noel Georgi <[email protected]>
Pull in dm-modules. Ref: siderolabs/pkgs#791 Diff: ```bash ❯ diff -r --color _out/kernel-a/lib/modules/6.1.51-talos/modules.dep _out/kernel-b/lib/modules/6.1.51-talos/modules.dep 100a101 > kernel/drivers/md/dm-bio-prison.ko: 102a104 > kernel/drivers/md/persistent-data/dm-persistent-data.ko: 103a106 > kernel/drivers/md/dm-thin-pool.ko: kernel/drivers/md/persistent-data/dm-persistent-data.ko kernel/drivers/md/dm-bio-prison.ko ``` Signed-off-by: Noel Georgi <[email protected]>
Add kernel modules for device-mapper.