feat: start the blkid work #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/blkid
branch
4 times, most recently
from
17b3dbf to
8b0708b
Compare
frezbo
reviewed
Feb 23, 2024
| kind: golang.Toolchain | ||
| spec: | ||
| extraPackages: | ||
| - cdrkit |
There was a problem hiding this comment.
i had to look up what was this 😅
Unix4ever
reviewed
Feb 23, 2024
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
||
| // Code generated by "cstruct -pkg ext -struct SuperBlock -input superblock.h -endianness LittleEndian"; DO NOT EDIT. |
frezbo
approved these changes
Feb 23, 2024
Unix4ever
reviewed
Feb 23, 2024
| "github.com/siderolabs/go-blockdevice/v2/blkid/internal/probers" | ||
| ) | ||
|
|
||
| func (i *Info) probe(f *os.File, offset, length uint64) error { |
There was a problem hiding this comment.
Are we going to have fallback to unknown FS if we found something we couldn't read?
There was a problem hiding this comment.
it just returns no information in the Info for now, so basically it will set some fields like block device sector size, but it won't set anything else in the info (it will be all empty)
Unix4ever
approved these changes
Feb 23, 2024
This first piece implements filesystem detection. Signed-off-by: Andrey Smirnov <[email protected]>
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first piece implements filesystem detection.