Adding multipath-tools extension #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where can I find the requirements for properly formatting my commit messages? |
frezbo
reviewed
Oct 28, 2024
| func main() { | ||
| fmt.Println("Starting multipath daemon...") | ||
|
|
||
| //setup a chroot environment for the extension |
There was a problem hiding this comment.
i don't think we need this, with mountPropogation shared should work as a normal extension service
frezbo
reviewed
Oct 28, 2024
| @@ -0,0 +1,1132 @@ | |||
| defaults { | |||
There was a problem hiding this comment.
this should be provided as an ExtensionServiceConfig
frezbo
reviewed
Oct 28, 2024
There was a problem hiding this comment.
this should just compile using base and put all libs under /rootfs/usr/local/lib/containers/multipath-tools/
There was a problem hiding this comment.
ok, sounds good, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new extension for multipath-tools. This is needed in the environment I work in, and probably others as well.
I intend for this PR to be an open conversation about this feature. I tried to implement this in a way that aligns with Talos goals and philosophy, but if there is any feedback on this please let me know.