-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create LICENSE #1
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
MIT License | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a standard MIT license and it seems correctly formatted and detailed. It does not contain any code, rather, it's a legal agreement that specifies the terms of use for the software. As such, there isn't any specific coding logic or programming practices to evaluate or critique in these terms. However, if you want to enhance this, here's a small suggestion:
This small change would keep the copyright current. Moreover, remember to replace "[current year]" with the actual current year. This isn't a program, so it won't automatically update. Also, ensure this license aligns with the desired openness and usage of the software being developed. Different licenses offer different levels of freedom for reuse, distribution, and modification. Lastly, make sure to include the license in every relevant source file, not only in the root directory of your project. |
||
|
||
Copyright (c) 2019 Siddhant Mishra | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provided text is a standard MIT License notice. It isn't source code, it's a software license agreement that governs the usage and distribution of a piece of software. These agreements are usually standardized legal documents and don't need to be written or modified by a programmer.
In this case, there seems to be no issues or mistakes in the license notice—it correctly and completely specifies the MIT License, including the copyright holder, permission statement, conditions, and disclaimers.
However, reviewing for improvement, there's very little to assess or suggest:
Ensure the copyright year and the name of the person/organization are correct. If not, replace "2019" and "Siddhant Mishra" with the correct year and copyright holder name respectively.
Usually, the software project's name could also be included. If you like, you could make it a little bit more specific like: "Copyright (c) 2019 Siddhant Mishra, [Project name]".
Although it's not an issue, but do make sure that an MIT License matches the intentions for the use of your software. It's one of the most permissive licenses, allowing for reuse in any manner, including proprietary use, as long as the license and copyright notice are included.
Ultimately, the major work here is not in the "coding" of the license (since it's mostly a copy-and-paste job), but in the legal and strategic decision of how you want your software to be used, reused, sold, and altered.