fix(cargo-shuttle): don't override user provided RUST_LOG on local run #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the logging configuration to respect user-defined RUST_LOG environment variables during local runs, preventing unwanted overrides of custom logging preferences.
- Modified
runtime/src/start.rsto use different default log levels for beta ('info') vs non-beta ('info,shuttle=trace') environments - Updated
cargo-shuttle/src/lib.rsto preserve user-provided RUST_LOG values instead of overriding them - Added conditional RUST_LOG setting that only applies in debug mode when user hasn't defined their own value
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes RUST_LOG override in
shuttle runreported in https://discord.com/channels/803236282088161321/1318703796007735306How has this been tested? (if applicable)
Local run with
RUST_LOG=tracenow showstrace!()logs from the user code.