-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: opendal on postgres output type, bump opendal #1928
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds OpenDAL support for PostgreSQL storage backend and updates the OpenDAL dependency to version 0.50, enabling key-value storage capabilities in Postgres databases.
- Added PostgreSQL backend support in
resources/shared-db/src/postgres.rs
with automatic table creation and key-value storage configuration - Updated OpenDAL dependency from 0.45 to 0.50 in
resources/opendal/Cargo.toml
with corresponding API changes (via_map
tovia_iter
) - Introduced new
opendal
feature flag inresources/shared-db/Cargo.toml
that properly bundles PostgreSQL service dependencies
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This PR improves error handling in PostgreSQL connections and refines the OpenDAL integration with better error propagation.
- Replaced
unwrap()
calls with proper error handling using?
operator inresources/shared-db/src/postgres.rs
- Added error type conversion for OpenDAL operations in
resources/opendal/src/lib.rs
- Implemented connection pool configuration validation with explicit minimum connections check in
resources/shared-db/src/postgres.rs
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This PR improves test coverage and documentation generation while fixing environment string parsing.
- Fixed incorrect assertion in
common/src/deployment.rs
test_env_deser function to properly test Environment::from_str - Added docs.rs metadata section in
common/Cargo.toml
to enable all features during documentation generation - Improved test coverage for Environment enum's FromStr implementation
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
No description provided.