Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opendal on postgres output type, bump opendal #1928

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jonaro00
Copy link
Member

No description provided.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds OpenDAL support for PostgreSQL storage backend and updates the OpenDAL dependency to version 0.50, enabling key-value storage capabilities in Postgres databases.

  • Added PostgreSQL backend support in resources/shared-db/src/postgres.rs with automatic table creation and key-value storage configuration
  • Updated OpenDAL dependency from 0.45 to 0.50 in resources/opendal/Cargo.toml with corresponding API changes (via_map to via_iter)
  • Introduced new opendal feature flag in resources/shared-db/Cargo.toml that properly bundles PostgreSQL service dependencies

4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

resources/shared-db/src/postgres.rs Outdated Show resolved Hide resolved
resources/shared-db/src/postgres.rs Show resolved Hide resolved
resources/shared-db/Cargo.toml Show resolved Hide resolved
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR improves error handling in PostgreSQL connections and refines the OpenDAL integration with better error propagation.

  • Replaced unwrap() calls with proper error handling using ? operator in resources/shared-db/src/postgres.rs
  • Added error type conversion for OpenDAL operations in resources/opendal/src/lib.rs
  • Implemented connection pool configuration validation with explicit minimum connections check in resources/shared-db/src/postgres.rs

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR improves test coverage and documentation generation while fixing environment string parsing.

  • Fixed incorrect assertion in common/src/deployment.rs test_env_deser function to properly test Environment::from_str
  • Added docs.rs metadata section in common/Cargo.toml to enable all features during documentation generation
  • Improved test coverage for Environment enum's FromStr implementation

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant