Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] nextra-mobile-nav #3758

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

hasparus
Copy link
Contributor

@hasparus hasparus commented Dec 2, 2024

Why:

Code that previously targeted the sidebar is broken without it and there's no other elegant way to target it.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added .nextra-sidebar-container class back.

Check off the following:

  • I have reviewed my changes in staging, available via the View
    deployment
    link in this PR's timeline (this link will be available after
    opening the PR).

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 57dcff7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:42am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 4:42am

Copy link

vercel bot commented Dec 2, 2024

@hasparus is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@hasparus hasparus changed the title v4 nextra-sidebar-class v4 nextra-sidebar-container Dec 2, 2024
@dimaMachina dimaMachina changed the title v4 nextra-sidebar-container [v4] nextra-mobile-nav Dec 3, 2024
@dimaMachina dimaMachina merged commit ea7bece into shuding:v4-v2 Dec 3, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants