Duplicate the context hash when duplicating an Attacher #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, a single context hash is shared between the original attacher and its duplicate. The changes in fc6a3ed update this shared hash after duplication to reference the duplicate model, leading to both the duplicate and original attacher having `context[:record]` pointing at the duplicated model.
|
Thanks for the patch, looks good 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit an issue following the upgrade to 3.5.0 where
context[:record]in anAttacher#finalizecall was set to an unpersisted duplicate of the record we were saving. This turned out to be because another part of our model save flow was duplicating the model for its own purposes and thecontexthash was shared between the original attacher and its duplicate.The changes in fc6a3ed added a call to
attacher_copy.set_entity(self, name) if attacher_copy. Because@contextin both attachers point at the same object, this ends up withcontext[:record]for both records pointing to the new duplicate model.