Add Spinner story #1006
Add Spinner story #1006
Conversation
Coteh
commented
Aug 27, 2020
•
Coteh
commented
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 52.58% 52.58%
=======================================
Files 142 142
Lines 3564 3564
Branches 168 168
=======================================
Hits 1874 1874
Misses 1623 1623
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Harry Liu <[email protected]>
story/src/2-Spinner.stories.tsx
Outdated
| }; | ||
|
|
||
| export const spinner = () => { | ||
| return <Spinner />; |
There was a problem hiding this comment.
Can we wrap the spanner with a background? It's too to see the orbitals and planet on storybook.
There was a problem hiding this comment.
I'll see what I can do with Storybook Backgrounds. I'll wrap the component with background as fallback in case that doesn't work out.
There was a problem hiding this comment.
Here's how it looks now, using the dark color that comes with Storybook Backgrounds addon
There was a problem hiding this comment.
One caveat, if you switch background color, it'll always stay that color, even when selecting Spinner story. I'm going to fallback to wrapping.
Coteh
dismissed
magicoder10’s stale review
We discussed in PR that we will let the style names go through for now, and revise the naming convention for SCSS module classnames later.
