Skip to content

Commit

Permalink
Merge branch 'next' of https://github.com/shoelace-style/shoelace int…
Browse files Browse the repository at this point in the history
…o next
  • Loading branch information
claviska committed Sep 14, 2023
2 parents 4d32979 + 1d28e1b commit 2ed5a4f
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 8 deletions.
4 changes: 4 additions & 0 deletions docs/pages/frameworks/react.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ If you'd rather not use the CDN for assets, you can create a [build task](https:

Now you can start using components!

### Preact

Preact users facing type errors using components may benefit from setting "paths" in their tsconfig.json so that react types will instead resolve to preact/compat as described in [Preact's typescript documentation](https://preactjs.com/guide/v10/typescript/#typescript-preactcompat-configuration).

## Usage

### Importing Components
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"dependencies": {
"@ctrl/tinycolor": "^4.0.1",
"@floating-ui/dom": "^1.2.1",
"@lit-labs/react": "^2.0.1",
"@lit-labs/react": "^2.0.3",
"@shoelace-style/animations": "^1.1.0",
"@shoelace-style/localize": "^3.1.1",
"composed-offset-position": "^0.0.4",
Expand Down
1 change: 1 addition & 0 deletions src/components/details/details.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export default class SlDetails extends ShoelaceElement {
}

disconnectedCallback() {
super.disconnectedCallback();
this.detailsObserver.disconnect();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export default class SlMutationObserver extends ShoelaceElement {
}

disconnectedCallback() {
super.disconnectedCallback();
this.stopObserver();
}

Expand Down
1 change: 1 addition & 0 deletions src/components/popup/popup.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ export default class SlPopup extends ShoelaceElement {
}

disconnectedCallback() {
super.disconnectedCallback();
this.stop();
}

Expand Down
1 change: 1 addition & 0 deletions src/components/tab-group/tab-group.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export default class SlTabGroup extends ShoelaceElement {
}

disconnectedCallback() {
super.disconnectedCallback();
this.mutationObserver.disconnect();
this.resizeObserver.unobserve(this.nav);
}
Expand Down

0 comments on commit 2ed5a4f

Please sign in to comment.