Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves most vendor items out of contraband. #3007

Merged
merged 6 commits into from
Jun 2, 2024

Conversation

Sadhorizon
Copy link
Contributor

@Sadhorizon Sadhorizon commented May 19, 2024

About The Pull Request

Moves a shit ton of vendor items out of contraband alongside a bunch of misc tweaks.

Why It's Good For The Game

Hacking kinda sucks as a mechanic. It brings nothing interesting and kinda just locks some perfectly normal items behind a pointless roadblock.

Changelog

🆑
tweak: Moved most of contraband items out of vendor contraband.
add: Added DromaderyCo packets to the cigarette vendors.
tweak: Increased nicotine amount to three in the cigarette vendors.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label May 19, 2024
@Sadhorizon Sadhorizon changed the title Tweaks to the cigarette vendor. Moves most vendor items out of contraband. May 19, 2024
Copy link
Contributor

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Stuff

code/modules/vending/games.dm Outdated Show resolved Hide resolved
code/modules/vending/medical.dm Show resolved Hide resolved
code/modules/vending/medical_wall.dm Show resolved Hide resolved
Copy link
Contributor

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Good

@rye-rice rye-rice added this pull request to the merge queue Jun 2, 2024
Merged via the queue into shiptest-ss13:master with commit 9bb6b54 Jun 2, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

Moves a shit ton of vendor items out of contraband alongside a bunch of
misc tweaks.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Hacking kinda sucks as a mechanic. It brings nothing interesting and
kinda just locks some perfectly normal items behind a pointless
roadblock.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
tweak: Moved most of contraband items out of vendor contraband.
add: Added DromaderyCo packets to the cigarette vendors.
tweak: Increased nicotine amount to three in the cigarette vendors.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

Moves a shit ton of vendor items out of contraband alongside a bunch of
misc tweaks.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Hacking kinda sucks as a mechanic. It brings nothing interesting and
kinda just locks some perfectly normal items behind a pointless
roadblock.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
tweak: Moved most of contraband items out of vendor contraband.
add: Added DromaderyCo packets to the cigarette vendors.
tweak: Increased nicotine amount to three in the cigarette vendors.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants