Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blastdoor and Atmos Holofield ID multitool syncing #3004

Merged
merged 6 commits into from
May 28, 2024

Conversation

Gristlebee
Copy link
Contributor

@Gristlebee Gristlebee commented May 19, 2024

About The Pull Request

Multitools can be used on a button with it's panel open to add a blast door or holofield controller to it's buffer.

The ID can be copied onto a blast door the same way as changing it normally with a multitool. For holofields, you need to have the access mode on unlocked and it's panel closed.

Adds holofield controllers to the autolathe.

Changes all the span classes to span macros

Why It's Good For The Game

When you have a roundstart blast door break or holofield break for whatever reason, it's almost impossible to replace and properly resync without ripping out the rest of the blastdoors or the other holofield. This should make reconstruction more convienent.

Also being able to make and use your own holofield controller adds a more intuitive way to rig up player made holofields, as currently you have to use signallers on the activation wire.

Changelog

🆑
add: Autolathe can print holofield controllers.
add: You can sync blastdoors and holofields to a controller in a button with a multitool
code: span macros for blast doors, buttons and holofields
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label May 19, 2024
@TheLeopold
Copy link
Contributor

Does it work with multiple buttons having the same set of doors?

@Gristlebee
Copy link
Contributor Author

Gristlebee commented May 26, 2024

Does it work with multiple buttons having the same set of doors?

Should be able to, yes.
To be more specific, as long as the buttons have the same ID code, yes.

Copy link
Contributor

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, might just merge since i doubt anyone will test this in a test merge!

code/game/machinery/buttons.dm Outdated Show resolved Hide resolved
code/game/machinery/shieldgen.dm Outdated Show resolved Hide resolved
Gristlebee and others added 2 commits May 28, 2024 00:48
Co-authored-by: FalloutFalcon <[email protected]>
Signed-off-by: Gristlebee <[email protected]>
Co-authored-by: FalloutFalcon <[email protected]>
Signed-off-by: Gristlebee <[email protected]>
@FalloutFalcon FalloutFalcon added this pull request to the merge queue May 28, 2024
Merged via the queue into shiptest-ss13:master with commit ae8f4e3 May 28, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jun 1, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Multitools can be used on a button with it's panel open to add a blast
door or holofield controller to it's buffer.

The ID can be copied onto a blast door the same way as changing it
normally with a multitool. For holofields, you need to have the access
mode on unlocked and it's panel closed.

Adds holofield controllers to the autolathe.

Changes all the span classes to span macros

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

When you have a roundstart blast door break or holofield break for
whatever reason, it's almost impossible to replace and properly resync
without ripping out the rest of the blastdoors or the other holofield.
This should make reconstruction more convienent.

Also being able to make and use your own holofield controller adds a
more intuitive way to rig up player made holofields, as currently you
have to use signallers on the activation wire.

## Changelog

:cl:
add: Autolathe can print holofield controllers.
add: You can sync blastdoors and holofields to a controller in a button
with a multitool
code: span macros for blast doors, buttons and holofields
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Gristlebee <[email protected]>
Co-authored-by: FalloutFalcon <[email protected]>
@Gristlebee Gristlebee deleted the blastdoors branch July 21, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants