Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handrails #3002

Merged
merged 8 commits into from
Jun 8, 2024
Merged

handrails #3002

merged 8 commits into from
Jun 8, 2024

Conversation

fighterslam
Copy link
Contributor

About The Pull Request

This adds handrails, from Baystation - original PR that added them is here. This doesn't actually add anything to any maps, but adds it as a structure for mappers to use. I did a little bit of work by adding a crafting recipe, and simplifying things by making it a chair subtype.

Why It's Good For The Game

It's like. You can grab onto them. Makes Zero-G ships better, helps with transits so people don't go awkwardly rushing to chairs or just flop to the floor.

Changelog

🆑 fighterslam, comma
add: Handrails, rails on the wall that you can grab/buckle yourself to. (*Not included in any maps with this PR, but craftable with 4 iron rods.)
🆑

@fighterslam fighterslam requested a review from a team as a code owner May 18, 2024 09:45
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels May 18, 2024
@FalloutFalcon
Copy link
Contributor

An image of them in game would be nice!

Copy link
Contributor

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concept is fine however the sprites could REALLY use some work, someone pointed out they would go well in sub shuttles. The sprites If you intend for it to be wall mounted it also needs offset sprites!
Make sure they have a material cost that matches the recipe since /chair/ has stuff related to it.
Chairs can also be rotated so take that into account.

@fighterslam
Copy link
Contributor Author

The sprite is 7+ years old and not something I made. It's just a rip from baystation. The price is 4 iron rods, which is 2 sheets. Deconstructing a chair only gives you 1 metal sheet, so it's not a perfect conversion - I don't think this is a problem, but if you want me to change it, I could. Being able to rotate it shouldn't be that big of an issue, people might place them wrong and need to rotate it. As far as the subshuttle comment, again, this hasn't been mapped in anywhere in this PR, and at the moment I don't have plans to go around adding it to people's maps.

If there's something you actually need me to change, please let me know, and please understand I am not an experienced coder and not a spriter. This is just a port of a feature that I want and a few other people have requested.

@fighterslam
Copy link
Contributor Author

@FalloutFalcon

@fighterslam
Copy link
Contributor Author

fighterslam commented May 22, 2024

Here's some examples of the sprites ingame. Against walls, rails, any structure, really. (Subshuttles.)

image
image

@fighterslam
Copy link
Contributor Author

In the Hyena-Class, it could fit in the airlock, or the hallways. This isn't part of the PR, just an example of how it could maybe be used.
image

Vaquero-Class.
image

@FalloutFalcon
Copy link
Contributor

Use buildstacktype from chair. make it give back what you put in

@FalloutFalcon FalloutFalcon added the Feature REALLY causes more bugs in the future that we won't know about. label May 24, 2024
@FalloutFalcon
Copy link
Contributor

thgvr requested to make them wall mounts,
use a /obj/item/wallframe to craft and place it.

@fighterslam
Copy link
Contributor Author

Thgvr retracted their statement about the wallmounts, is there anything else that needs doing @FalloutFalcon ?

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Jun 8, 2024
Merged via the queue into shiptest-ss13:master with commit 0449e6d Jun 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Feature REALLY causes more bugs in the future that we won't know about. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants