Sourcery Starbot ⭐ refactored shispt/discover-books #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Mar 9, 2022
| if all([not t.is_alive() for t in threads]): | ||
| if all(not t.is_alive() for t in threads): |
There was a problem hiding this comment.
Function start_crawler refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
| return True if match else False | ||
| return bool(match) |
There was a problem hiding this comment.
Function is_douban_book_url refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity)
Comment on lines
-81
to
+93
| result = dict() | ||
| for key, column in [ | ||
| return { | ||
| key: re.search( | ||
| pattern.format(column, end_flag), text, re.I | re.DOTALL | ||
| ) | ||
| .group(1) | ||
| .strip() | ||
| for key, column in [ | ||
| ('author', '作者'), | ||
| ('press', '出版社'), | ||
| ('publish_date', '出版年'), | ||
| ('price', '定价')]: | ||
| result[key] = re.search(pattern.format(column, end_flag), | ||
| text, | ||
| re.I | re.DOTALL).group(1).strip() | ||
| return result | ||
| ('price', '定价'), | ||
| ] | ||
| } |
There was a problem hiding this comment.
Function _parse_book_info refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace dict() with {} (
dict-literal) - Convert for loop into dictionary comprehension (
dict-comprehension)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: