Compability, Versioning and Upgrading Penthouse and Using Docker & CircleCI for Developer Experience

[simonireilly]

This branch is a work in progress that will allow penthouse to be used with multiple versions of Rails.

Requirement

Working through these changes it's clear that there will be a little more work that needs to reach 5.2.0.

This diff command is really helpful for anyone looking to see the reason behind these changes:

git clone [email protected]:rails/rails.git
cd rails
git diff v5.1.5.rc1 v5.2.0.rc1 ./activerecord/lib/active_record/migration.rb

Major Changes

• We can run everything in docker, see Dockerfile.test for how to inject Ruby, ActiveRecord and pg versions into the gemfile.
  • There is also a compose file for running this with a postgres sidecar which works, see the Makefile
• database.test.yml and octopus.test.yml are commited to source control so no-one has to do manual setups when testing
• I added an ActiveRecord logger in testing mode, this will make managing the gem and debugging much easier.
• Now Ci is running (and passing) on CircleCI.
• We now use the standardrb for linting.
• Migrator was removed in ActiveRecord 5.2, it is now put on the MigrationContext. There is a version safe class module inclusion now in Penthouse.

Version Support

Testing has been set up to support ActiveRecord:

• 4.2.11.1
• 5.1.7
• 5.2.3
• 6.0.0 - There is a know issue with ar-octopus Octopus error at startup with Rails 6: alias_method': undefined method any?' for class `ActiveRecord::Associations::CollectionAssociation' (NameError) thiagopradi/octopus#540

Post Merge

• Drop codeship as a testing service
• create a tagged release for supporting ActiveRecord 5.2

Seeking Feedback On

• Additional test coverage wanted
• Additional readme documentation

[simonireilly]

We should split out the CI upgrade and move it into it's own PR.

Then we can proceed with the refactor.

[simonireilly]

When we try and add support these versions might need bumped

[simonireilly]

@ryantownsend this is the only change.

See the release thiagopradi/octopus@1c99859

Our version lock: https://github.com/shiftcommerce/flex-platform/blob/4e1e9040e31e95c8975ec23acc4c0e014feb5f1d/Gemfile#L38-L42

Looks like v0.9.2 could be an option aswell

[simonireilly]

Might make sense to perform the platform update first; then perform the Penthouse update

[simonireilly]

Merged as I had only bumped a dev dependency.