refactor api initialization #3990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiytor
force-pushed
the
refactor/api-initialization
branch
4 times, most recently
from
22bd55b to
62b98aa
Compare
heiytor
force-pushed
the
refactor/api-initialization
branch
from
62b98aa to
56631e5
Compare
heiytor
force-pushed
the
refactor/api-initialization
branch
from
56631e5 to
dff2b99
Compare
- Introducing a new struct `Server` to manage server start and shutdown. - Move environment variables to a `Server` attribute. - Move server shutdown to `main.go` and removed useless `ContextWithCancel`.
heiytor
force-pushed
the
refactor/api-initialization
branch
from
dff2b99 to
de8f6bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.