Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent,api,gateway,pkg,ssh: add public url to access HTTP application on device #2534

Merged
merged 1 commit into from
Mar 9, 2023
Merged

agent,api,gateway,pkg,ssh: add public url to access HTTP application on device #2534

merged 1 commit into from
Mar 9, 2023

Conversation

henrybarreto
Copy link
Member

No description provided.

@henrybarreto henrybarreto self-assigned this Mar 2, 2023
@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch from 41a5abe to 99bffb1 Compare March 2, 2023 18:24
@henrybarreto
Copy link
Member Author

Related to: #90

@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch 2 times, most recently from ad70200 to 338f148 Compare March 2, 2023 20:26
@henrybarreto henrybarreto marked this pull request as ready for review March 2, 2023 20:27
@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch 2 times, most recently from db7ab43 to c7e4748 Compare March 2, 2023 21:38
@gustavosbarreto gustavosbarreto self-requested a review March 3, 2023 02:46
@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch 2 times, most recently from 29ccfa0 to 6113214 Compare March 3, 2023 12:34
@henrybarreto henrybarreto added this to the Q1-2023 milestone Mar 3, 2023
@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch 4 times, most recently from 135382c to 29ce743 Compare March 7, 2023 19:28
otavio
otavio requested changes Mar 7, 2023
View reviewed changes
agent/main.go Outdated Show resolved Hide resolved
gateway/shellhub.conf Outdated Show resolved Hide resolved
pkg/api/client/client.go Outdated Show resolved Hide resolved
pkg/api/client/client_public.go Outdated Show resolved Hide resolved
ssh/main.go Outdated Show resolved Hide resolved
ssh/main.go Outdated Show resolved Hide resolved
@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch from 29ce743 to 2c4b397 Compare March 8, 2023 13:06
@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch 3 times, most recently from 7d41656 to 55ce82c Compare March 8, 2023 13:27
otavio
otavio previously approved these changes Mar 9, 2023
View reviewed changes
@otavio otavio self-requested a review March 9, 2023 01:44
@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch 4 times, most recently from ff3128d to bb8179d Compare March 9, 2023 15:09
@henrybarreto henrybarreto force-pushed the feature/devicePublicURL branch from bb8179d to 570a2c7 Compare March 9, 2023 20:13
@gustavosbarreto gustavosbarreto merged commit be29141 into master Mar 9, 2023
@gustavosbarreto gustavosbarreto deleted the feature/devicePublicURL branch March 9, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavosbarreto gustavosbarreto Awaiting requested review from gustavosbarreto

@otavio otavio Awaiting requested review from otavio

Assignees

@henrybarreto henrybarreto

Labels
area/agent area/api area/ssh Epic go Pull requests that update Go code kind/feature New feature or request status/needs-review status/require-tests
Projects
None yet
Milestone
Q1-2023
Development

Successfully merging this pull request may close these issues.
3 participants
@henrybarreto @otavio @gustavosbarreto