Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/allow AllowTcpForwarding #2164

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

benasse
Copy link
Contributor

@benasse benasse commented Sep 29, 2022

Hello shellhub developers,

First of all, thank you for this great project, it answers a real need when you have to connect to various linux machines distributed in non mastered network environment.

A feature that I was missing to be able to use shellhub in my ecosystem is the ability to perform port forwarding.

Other people have reported this need here: #90

I took the time to examine the code and make this feature work.

With this pull request it is possible to connect with ssh to a device and specify a port forwarding like this:

ssh user@<shellhub_device>@<shellhub_host> -L 0.0.0.0:42667:192.168.8.13:443

What do you think of it?

@benasse
Copy link
Contributor Author

benasse commented Sep 29, 2022

After some testing, this PR would allow this functionality: #513

I don't have a test environment to be sure, but it may have an impact on : #327 and #489

@gustavosbarreto
Copy link
Member

@benasse I'm traveling to the GopherCon Brazil right now. I will look into it as soon as possible.

improve login format
@benasse
Copy link
Contributor Author

benasse commented Sep 30, 2022

Thanks for the feedback, have a nice trip and a good GopherCon !

@gustavosbarreto
Copy link
Member

gustavosbarreto commented Oct 3, 2022

@benasse Thanks for implementing this. It will be very useful for many use cases.

LGTM

@gustavosbarreto gustavosbarreto merged commit f9f643e into shellhub-io:master Oct 3, 2022
@whyameye
Copy link

How can I use this added feature to implement X11 forwarding specifically?

@benasse
Copy link
Contributor Author

benasse commented Jul 24, 2023

As far as I know, X11 forwarding uses a unix socket, which is not currently supported by shellhub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants