Adding Swedish translation

[yeager]

No description provided.

[DanielSvoboda]

You need to add the reuse text, and I think you have to add it to the list on the configuration screen for it to work. And this is missing 330 lines.

[yeager]

Not sure about this. Where and how?

I see Swedish in QStringList languageNames in src/qt_gui/settings_dialog.cpp

[yeager]

There are no lines missing. I have used "-locations none" to remove paths

[DanielSvoboda]

The formatting of spaces also doesn't seem to be the same as the others. And there are several inconsistencies, such as the mixed content of main_window_ui.h and main_window.cpp and the lack of translation of the sentences that end in '_MSG'. To solve all the problems, I recommend making a copy of the English en.ts file and making the changes from there, changing only what is inside < translation >

[DanielSvoboda]

Not sure about this. Where and how?

I see Swedish in QStringList languageNames in src/qt_gui/settings_dialog.cpp

'Swedish' is present in the 'console Language' list but is not in the 'emulator Language', just different things.

[yeager]

I used the English en.ts and cleaned it with lconvert
$ lconvert -drop-translations -i en.ts -o untranslated.ts
$ lconvert -locations none -i untranslated.ts -o sv_SE.ts

Then used Qt Linguist to translate the file.

The use of the MSG's are not really the best way.
Maybe put the proper text instead of the MSG?
This would make it easier for translators..

Noticed that while dropping the translations, I lost the proper text for the MSG's
I will update them right now

Still have no idea where to add Swedish as an emulator language in the UI

[DanielSvoboda]

now it's better, I'll make a PR to fix some things later.

Which sentence could be in place of:
"Uppdatera kompatibilitetsdatabasen vid uppstart"
It needs to be something smaller so as not to deform the entire interface

[DanielSvoboda]

@dima-xd This file is not using the 'location' tag, but it works without it. I found it interesting that there are currently 2 'context' called MainWindow, one for main_window.cpp and another for main_window.h, and so without the 'location' everything was unified into one. Do you think we should standardize all of them without the 'location' or should the sv_SE file add it?

[dima-xd]

@dima-xd This file is not using the 'location' tag, but it works without it. I found it interesting that there are currently 2 'context' called MainWindow, one for main_window.cpp and another for main_window.h, and so without the 'location' everything was unified into one. Do you think we should standardize all of them without the 'location' or should the sv_SE file add it?

Yeah, I think we can get rid of location tag in all files since it works without it. It will help users with translations

[yeager]

A short version of "Uppdatera kompatibilitetsdatabasen vid uppstart" would be "Uppdatera databas vid uppstart".

"Swedish" in Swedish is "Svenska" :-)

Qt also uses "locations none" for their translations.

Thanks, guys

[DanielSvoboda]

I created this PR on your branch, to remove the 'location' and adjust everything, I believe you have to merge it

[yeager]

Looks much better now. Thanks

[DanielSvoboda]

This is another sentence that can be shortened to make it better:
"Leta efter uppdateringar vid uppstart"
appears in 2 places. Maybe use: 'Uppdateringar vid start'

[yeager]

Yeah, looks good. Obrigado. Your Swedish is amazing :)

[yeager]

How is this file in conflict with Finnish fi.ts?
Ok to commit now?

[DanielSvoboda]

in PR2057 changes were made to the text in the fi.ts language, and it is now in conflict with your PR, so resolve the conflict by leaving the texts updated in Finnish

[yeager]

Huh. I didn't do the Finnish translation. Completely different file.
What shall I do?

[DanielSvoboda]

You didn't make any changes to it, but I made a PR within yours, remember that you accepted it, I changed all the translation files, all the languages, removing the 'location' tag. So your PR changed this file too, you have to press to resolve the conflict, keep the same current structure and insert the new texts