Multi-stage Dockerfile

[yfdyh000]

I expect it to improve slow docker build locally.

alpine:3.14 updated. FYI:
https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.13.0
https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0

I expect the COPY --chown=nginx:nginx shaarli_version.php /var/www/shaarli/ ensure a clean cache for release. Although this may not be effective for dev branches, and an inconsistent results for the developer local. I still want to pass a variable or if, only erase in cloud builds.

If the && rm -rf ./node_modules be removed, it will build quickly, but the docker image size + 50MiB, which seems not easy to solve.

[nodiscc]

This looks good, thank you. It also improves the situation regarding #1655. Using --chown=nginx:nginx to workaround docker/for-linux#388 is interesting 👍

Currently the CI configuration only builds Docker images for master and git tags, hence the Docker build did not trigger for this PR. To properly test this we should add a workflow that builds Docker images from Pull Requests (without pushing to dockerhub, credentials are not available outside protected branches/tags anyway).

Did you measure build times after/before the patch?

[nodiscc]

as app is confusing, shouldn't it be as node or as frontend?

[yfdyh000]

It copy the . to /tmp, I hope to distinguish it with package build only. The frontend looks good. I used to use it as the final step, so I have renamed to app, but this case no longer exists.

[yfdyh000]

This looks good, thank you. It also improves the situation regarding #1655. Using --chown=nginx:nginx to workaround docker/for-linux#388 is interesting 👍

Currently the CI configuration only builds Docker images for master and git tags, hence the Docker build did not trigger for this PR. To properly test this we should add a workflow that builds Docker images from Pull Requests (without pushing to dockerhub, credentials are not available outside protected branches/tags anyway).

I don't know how to do this at this point, so welcome to help or push.

Did you measure build times after/before the patch?

On an old machine, it exceeds 300s before, now about 100 seconds at node_modules, just < 10s if the node_modules keep, > 600s if RUN chown -R nginx:nginx /var/www/shaarli/ runs.

[nodiscc]

To properly test this we should add a workflow that builds Docker images from Pull Requests (without pushing to dockerhub, credentials are not available outside protected branches/tags anyway).

I don't know how to do this at this point, so welcome to help or push.

I will try to get it working as soon as possible #1800

[nodiscc]

The changes in this PR are outdated/need to be rebased (or redone from scratch, which is probably easier). The main goal is to workaround docker/for-linux#388 (Docker bug from 2018 - Recursive chown is really slow).

The main change implemented here is the use of COPY --chown=nginx:nginx Dockerfile instruction instead of RUN chown -R nginx:nginx /var/www/shaarli/.

It should be investigated again to see if it improves build times.