Feature/template resolution by external service #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yervand Aghababyan <[email protected]>
Signed-off-by: Yervand Aghababyan <[email protected]>
…ervice # Conflicts: # core/core-services-impl/src/test/java/com/sflpro/notifier/services/template/impl/TemplatingConfigurationImplTest.java
…ervice # Conflicts: # core/core-services-impl/src/test/java/com/sflpro/notifier/services/template/impl/TemplatingConfigurationImplTest.java
dnavre
reviewed
May 19, 2022
docs/template-resolution.md
Outdated
| Configuration example | ||
| ```yaml | ||
| configuration: | ||
| example: |
There was a problem hiding this comment.
Please update the documentation.
dnavre
reviewed
May 19, 2022
| @@ -0,0 +1,45 @@ | |||
| # Template resolution strategies | |||
There was a problem hiding this comment.
Please go over this file and update it in accordance with the implementation. Then link this file from the main README.md as the place where one can read more about the templating config.
…ervice # Conflicts: # core/core-services-impl/src/test/java/com/sflpro/notifier/services/template/impl/TemplatingConfigurationImplTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.