Skip to content

Commit

Permalink
Fix a few other nits before landing
Browse files Browse the repository at this point in the history
  • Loading branch information
mrobinson committed May 13, 2024
1 parent eccaa92 commit 688f0ac
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
6 changes: 2 additions & 4 deletions components/script/dom/document.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3228,8 +3228,7 @@ impl Document {
}
}

/// Note a pending animation tick,
/// to be processed at the next `update_the_rendering` task.
/// Note a pending animation tick, to be processed at the next `update_the_rendering` task.
pub fn note_pending_animation_tick(&self, tick_type: AnimationTickType) {
self.pending_animation_ticks.borrow_mut().extend(tick_type);
}
Expand All @@ -3245,8 +3244,7 @@ impl Document {
}
}

/// Note a pending compositor event,
/// to be processed at the next `update_the_rendering` task.
/// Note a pending compositor event, to be processed at the next `update_the_rendering` task.
pub fn note_pending_compositor_event(&self, event: CompositorEvent) {
let mut pending_compositor_events = self.pending_compositor_events.borrow_mut();
if matches!(event, CompositorEvent::MouseMoveEvent { .. }) {
Expand Down
9 changes: 5 additions & 4 deletions components/script/script_thread.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1724,14 +1724,15 @@ impl ScriptThread {
// TODO: Perform pending transition operations from
// https://drafts.csswg.org/css-view-transitions/#perform-pending-transition-operations.

// TODO(#31021: Run the update intersection observations steps from
// TODO(#31021): Run the update intersection observations steps from
// https://w3c.github.io/IntersectionObserver/#run-the-update-intersection-observations-steps

// TODO: Mark paint timing from https://w3c.github.io/paint-timing.

// TODO: Update the rendering: consolidate all reflow calls into one here?(#31871)
// TODO(#31871): Update the rendering: consolidate all reflow calls into one here?

// TODO: process top layer removals(https://drafts.csswg.org/css-position-4/#process-top-layer-removals)
// TODO: Process top layer removals according to
// https://drafts.csswg.org/css-position-4/#process-top-layer-removals.
}
}

Expand Down Expand Up @@ -1773,7 +1774,7 @@ impl ScriptThread {
);
}

/// Handle incoming control messages.
/// Handle incoming messages from other tasks and the task queue.
fn handle_msgs(&self) -> bool {
use self::MixedMessage::{
FromConstellation, FromDevtools, FromImageCache, FromScript, FromWebGPUServer,
Expand Down

0 comments on commit 688f0ac

Please sign in to comment.