Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the CI environment #638

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

ynishimura
Copy link
Collaborator

Overview

Update Node.js version from 14 to 18 in GitHub Actions to resolve compatibility issues with the Object.hasOwn method.

Changes

  • Update the libraries in use
  • Update Node.js version from 14 to 18
  • Modified npm install command to use --legacy-peer-deps flag

Background

The following error occurs when running tests in the current CI environment:

 1) #compileStateMachines
       should validate definition and pass:
     TypeError: Object.hasOwn is not a function
      at new JSONPath (node_modules/jsonpath-plus/dist/index-node-cjs.cjs:1530:22)
      at JSONPath (node_modules/jsonpath-plus/dist/index-node-cjs.cjs:1509:14)
      at missingTransitionTargetErrors (node_modules/asl-validator/dist/src/checks/missing-transition-target-errors.js:9:34)
      at validator (node_modules/asl-validator/dist/src/validator.js:35:104)
      at /home/runner/work/serverless-step-functions/serverless-step-functions/lib/deploy/stepFunctions/compileStateMachines.js:119:45
      at Array.forEach (<anonymous>)
      at ServerlessStepFunctions.compileStateMachines (lib/deploy/stepFunctions/compileStateMachines.js:94:34)
      at Context.<anonymous> (lib/deploy/stepFunctions/compileStateMachines.test.js:1394:29)
      at processImmediate (internal/timers.js:464:21)

Impact

  • Changes only affect CI/CD environment
  • No impact on application code

@ynishimura ynishimura requested a review from horike37 December 18, 2024 05:26
@horike37 horike37 merged commit c49697b into serverless-operations:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants