Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiple custom templates #632

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lxhunter
Copy link

@lxhunter lxhunter commented Nov 6, 2024

Hey Guys,

i needed to implement custom templates for different status codes.

As I did not contribute a lot to open source projects before, please go easy on me ;)

I added tests, added documentation and build the functionality so that i does not break backwards compatibility.

Please let me know if i should change anything.

May the love be with you,
Lx

@horike37
Copy link
Collaborator

horike37 commented Nov 6, 2024

@lxhunter
Thank you for your contribution! That's a good functionality for this plugin.
But Some linting errors happen. which are coding rules you have to follow. Would you check and fix them?

@lxhunter
Copy link
Author

lxhunter commented Nov 6, 2024

@horike37
I fixed the linting errors, but still have an error regarding the reponseParameters left to fix.
I will fix it tomorrow and get back to you!

Thanks for the fast feedback

@lxhunter
Copy link
Author

@horike37 so the work and testing is done, please have a look and tell me if it is okay.

OFFTOPIC: would you be interested, that i merge the functionality from my plugin (https://github.com/the-fittest/serverless-step-function-sync) into this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants